Imteyaz, The change looks good to me, but I have a minor comment on your change. Would you mind to take a look?
Thanks, -Ian. On Mon, Dec 31, 2018 at 10:57 PM Imteyaz Khan <[email protected]> wrote: > Hi All, > I have raised PR <https://github.com/apache/incubator-dubbo/pull/3108> > for > dubbo-config-api. In this PR have replaced the pending hard coded values > with constant so that we can minimize accidental issue due to hard coded > value used in multiple places. I have created the issue (3107 > <https://github.com/apache/incubator-dubbo/issues/3107>) for the same. > > Please review. > > https://github.com/apache/incubator-dubbo/pull/3108 >
