Hi, On Tue, Jan 8, 2019 at 5:47 PM Mercy <[email protected]> wrote: > > Hi, > > I'd like to take the dubbo-registry-nacos as a registry > implementation and put the source code into dubbo branch 2.6.6+, what's > your opinion?
Do you mean put it into the core repository[1]? We used to put these modules into different repositories. But I think this leads to a problem that if more and more repositories come in, it will be difficult to manage the releases. This make me think that putting all the modules into the core repository. The advantages are: 1. easy to manage the release of the modules like dubbo-registry-nacos 2. concentrate the users and contributors into one repository, it is easy to track and identify the contributors The disadvantage will be the all-in-one jar will be very large. I think I prefer the first one: put dubbo-registry-nacos into core repository. How do others think? [1] https://github.com/apache/incubator-dubbo > > Kind regards, > > Mercy > > 在 2018/12/25 下午5:44, Huxing Zhang 写道: > > Hi, > > > > On Sun, Dec 23, 2018 at 4:48 AM Justin Mclean <[email protected]> > > wrote: > >> Hi, > >> > >>> Yes, both of them are Dubbo ppmc member.cI think we need a software grant > >>> here, shall we? > >> Give both people involved have signed ICLAs and the code in Apache > >> licensed it’s probably not required. It may depend on who actually owns > >> the code (usually the company those people work for but it depends on > >> their employment conditions and contract). > > According to my knowledge, I think the company owns the code. It's > > better to have a software grant there. > > > >> Thanks, > >> Justin > > > > -- Best Regards！ Huxing
