Hi, On Mon, Jan 14, 2019 at 11:00 AM Huxing Zhang <[email protected]> wrote: > > Hi, > > Just a quick check: > > - We may need NOTICE file in the source release
This is a required file for an Apache release[1]. > - I found .png file in source release, which is a binary file, it that > allowed? Did not confirm with ASF release policy yet. I check the ASF docuemention, there is no restriction not to include a png file. I think it is safe to leave it there. Besides, since they are only used by dubbo-spring-boot-autoconfigure/README module, I think we can move it into it. Besides, I checked following for the 0.2.1 release: - UT can passed on Java 8. - Could not build under Java 11, I filed an issue[2], I think it is does not block this release. - DISCLAIMER does not exist. Need to add it, your can refer to [3] - NO public keys found in KEYS[4] file, we need that to verify the release - SHA512 checksum ok - gpg signature: not checked - Apache rat plugin should be added, I did it manually and all look good to me. I think we should fix the NOTICE and DISCLAIMER issue before the release. [1] http://www.apache.org/legal/release-policy.html#licensing-documentation [2] https://github.com/apache/incubator-dubbo-spring-boot-project/issues/383 [3] https://github.com/apache/incubator-dubbo/blob/master/DISCLAIMER [4] https://dist.apache.org/repos/dist/dev/incubator/dubbo/KEYS > > On Wed, Jan 9, 2019 at 5:52 PM Mercy Ma <[email protected]> wrote: > > > > Hello Dubbo Community, > > > > This is a call for the vote to release Apache Dubbo Spring Boot Project > > (Incubating) versions 0.2.1(Spring Boot 2.x) and 0.1.2(Spring Boot 1.x). > > > > The release candidates: > > 0.2.1: > > https://dist.apache.org/repos/dist/dev/incubator/dubbo/spring-boot-project/0.2.1/ > > 0.1.2: > > https://dist.apache.org/repos/dist/dev/incubator/dubbo/spring-boot-project/0.1.2/ > > > > Git tag for the release: > > 0.2.1: > > https://github.com/apache/incubator-dubbo-spring-boot-project/tree/0.2.1-release > > 0.1.2: > > https://github.com/apache/incubator-dubbo-spring-boot-project/tree/0.1.2-release > > > > Hash for the release tag: > > 0.2.1: 64095bc0996e500c125fbd97ccb114edd88592a9 > > 0.1.2: 023fe06b8d69e4ef29923d685ed79259c1019344 > > > > Release Notes: > > 0.2.1: > > https://github.com/apache/incubator-dubbo-spring-boot-project/releases/tag/0.2.1 > > 0.1.2: > > https://github.com/apache/incubator-dubbo-spring-boot-project/releases/tag/0.1.2 > > > > The artifacts have been signed with Key: 28681CB1, which can be found in > > the keys file: > > https://dist.apache.org/repos/dist/dev/incubator/dubbo/KEYS > > > > The vote will be open for at least 72 hours or until the necessary number > > of votes are reached. > > > > Please vote accordingly: > > > > [ ] +1 approve > > [ ] +0 no opinion > > [ ] -1 disapprove with the reason > > > > Thanks, > > The Apache Dubbo (Incubating) Team > > > > -- > Best Regards！ > Huxing -- Best Regards！ Huxing
