Thanks，I'll fix the license issue and the package name as well On Sat, Feb 2, 2019 at 2:41 PM Huxing Zhang <hux...@apache.org> wrote:
> Hi, > > As a complementary, I did some further checks: > > - All source files have ASF headers. > - The contents of the release match with the 0.1 tag. > - No unexpected binary > > I think we need to add the maven rat plugin to avoid potential license > header issues. Therefore I filed an issue here[1]. > > [1] https://github.com/apache/incubator-dubbo-ops/issues/290 > > On Sat, Feb 2, 2019 at 11:50 AM Huxing Zhang <hux...@apache.org> wrote: > > > > Hi, > > > > I found some issues in the LICENSE and NOTICE, I think it's better to > fix it. > > > > I checked: > > > > - incubating in name > > - No Alibaba License > > - DISCLAIMER exist > > - signatures and hashed are good > > - LICENSE and NOTICE has some issues, see below > > - can compile from source > > - binary files contains license, notice, DISCLAIMER > > - binary works fine > > - It is better to specify a README or a shell script in the binary > > release to help user easy to start. > > > > > > It is better to specify the files and the license info in more detail > > in LICENSE. > > > > For dubbo-admin-frontend/static/fonts > > This product bundles files from google fonts roboto which is licensed > > under the Apache License v2. > > For details, see > > https://github.com/google/fonts/blob/master/apache/roboto/LICENSE.txt > > > > It is better to use link to a tag since it is immutable, but due to > > there is no tag in this repo, I think it is ok to link to master. > > > > For dubbo-admin-frontend/static/OpenSans.css > > This product bundles files from and google material design icons which > > is licensed under the Apache License v2. > > For details, see > > https://github.com/google/material-design-icons/blob/3.0.1/LICENSE > > > > Note that 3.0.1 is just an example, I am not sure what exact version > > it is, please verify it. > > > > Regarding the NOTICE file, I found there is no NOTICE for google fonts > > roboto, but there is a COPYRIGHT.txt[1] file there, therefore I think > > it is better to include it in the NOTICE file. On the other hand, the > > material-design-icons does not have NOTICE file, I think there is no > > need to include in NOTICE. Therefore I suggest to change NOTICE to > > following: > > > > Apache Dubbo OPS (incubating) > > Copyright 2018-2019 The Apache Software Foundation > > > > This product includes software developed at > > The Apache Software Foundation (http://www.apache.org/). > > > > This product contains code form the google fonts roboto: > > > > Google Fonts roboto > > =================== > > please visit google fonts for more information: > > * https://fonts.google.com/specimen/Roboto > > Copyright 2011 Google Inc. All Rights Reserved. > > > > [1] > https://github.com/google/fonts/blob/master/apache/roboto/COPYRIGHT.txt > > > > On Fri, Feb 1, 2019 at 3:49 PM Minxuan Zhuang <z82507...@gmail.com> > wrote: > > > > > > Hello Dubbo Community, > > > > > > This is a call for the vote to release Apache Dubbo OPS(Incubating) > > > version 0.1 > > > > > > The release candidates(RC2): > > > 0.1: > > > https://dist.apache.org/repos/dist/dev/incubator/dubbo/dubbo-ops/0.1/ > > > > > > Git tag for this release: > > > 0.1: https://github.com/apache/incubator-dubbo-ops/releases/tag/0.1 > > > > > > Hash for the release tag: > > > 0.1: 90b9e5662eb50c83ca2d4325ad025fa80a6cae38 > > > > > > Release Notes: > > > 0.1: > > > *https://github.com/apache/incubator-dubbo-ops/releases/tag/0.1 > > > <https://github.com/apache/incubator-dubbo-ops/releases/tag/0.1>* > > > > > > The artifacts have been signed with Key: DA2108479B0C1E71, which can be > > > found in > > > the keys file: > > > > > > *https://dist.apache.org/repos/dist/dev/incubator/dubbo/KEYS > > > <https://dist.apache.org/repos/dist/dev/incubator/dubbo/KEYS>* > > > > > > The vote will be open for at least 72 hours or until the necessary > number > > > of votes are reached. > > > > > > Please vote accordingly: > > > > > > [ ] +1 approve > > > [ ] +0 no opinion > > > [ ] -1 disapprove with the reason > > > > > > Thanks, > > > The Apache Dubbo (Incubating) Team > > > > > > > > -- > > Best Regards！ > > > > Huxing > > > > -- > Best Regards！ > Huxing >
