> In addition, I found that we still have a few Filters that are currently > problematic in asynchronous scenarios, such as: > > * ActiveLimitFilter > * TraceFilter
I noticed you have raised a PR trying to make these two filters work in an async way, I will take a look at it later today and leave my feedbacks there. Jun > On Feb 15, 2019, at 2:55 PM, yuhang xiu <carry...@gmail.com> wrote: > > Hi, everyone > > Recently, I found that dubbo does not handle the data generated during the > call process when it is asynchronous. > > For example, in TimeoutFilter, we used invocation#attachments to hold the > data that needs to be passed (start time in TimeoutFilter). But I don't > think this way is good, although using Invocation.attachments to pass data > does not pollute RpcContext. > > Perhaps a better way is to add a temporary attachment to the Invocation > that only maintains the temporary data generated during the call. > > In addition, I found that we still have a few Filters that are currently > problematic in asynchronous scenarios, such as: > > * ActiveLimitFilter > * TraceFilter > > We should determine a plan as soon as possible and then proceed to fix > these Filters.
