This is a good improvement to make it immutable. This PR looks good to me. But when look at URLBuilder file, it's big one and has many logic for parameter checking. I'm not sure if there is any library can do similar thing more easier.
maybe something like: https://immutables.github.io/ ? If anyone has any experience about immutables library or other similar library, not sure it's suitable for this scenario? On 2019/02/26 09:52:30, jun liu <[email protected]> wrote: > Hi, > > Someone has provided a new way for building URL, it can reduce recreation of > URLs while keep URL's immutable nature. Please share your thoughts on this PR: > https://github.com/apache/incubator-dubbo/pull/3500 > > Jun > >
