+1 to squash Keep commit history more clear
On 2019/03/14 07:57:20, Ian Luo <[email protected]> wrote: > I think it is a bad idea to keep all commit messages since it will > introduce the difficulty on maintenance. In fact, I love squash, and I > believe most of github users love it too, since it usually encourages > cleaner commit history :). But I strongly agree the person who merges the > pull request should take care of cleaning up the title and the content of > the pull request. > > -Ian. > > On Wed, Mar 13, 2019 at 12:34 AM Huxing Zhang <[email protected]> wrote: > > > Hi, > > > > Dubbo uses squashed commit when merge pull request, which means > > multiple commits will be merged into one. > > > > Sometimes I do see lots of commits in a pull request, my question is > > do you think it is necessary to keep all of them? For example, in this > > commit[1], some of them are duplicate, I think the person who merge > > the commit should be responsible to summarized it, what I normally do > > is: > > - reduce the content by removing duplicates. > > - removing the extra new lines to make it concise > > - format the message with [DUBBO-XXX] if possible. > > > > Not sure how other might think. > > > > [1] > > https://github.com/apache/incubator-dubbo/commit/d2b5914c359758d7339e028938bc62cad1183c0b > > > > > > -- > > Best Regards！ > > Huxing > > >
