Hi Justin
I run "npm ls | grep echarts" on tag 0.2.0, but gets no result. dubbo
admin use echarts 4.0.4 to support metrics on develop branch, but the
feature is not in the release
On Thu, Mar 21, 2019 at 2:11 PM Huxing Zhang <[email protected]> wrote:
> Hi,
>
> On Thu, Mar 21, 2019 at 1:45 PM Justin Mclean <[email protected]> wrote:
> >
> > Hi,
> >
> > > These dependencies are all development time dependencies, which can be
> > > found in "devDependencies" section of package.json file.
> >
> > Anyone who compiles the source will get these and be unaware of them,
> that seems a little problamatic to me.
>
> wordwrap is a transitive dependency of eslint, which I believe almost
> all the node.js projects will use.
> I also check the latest version of eslint, the dependency to wordwrap
> still exist.
> If that is the case, I doubt that there are lots of ASF projects could
> not make releases.
>
>
>
>
> >
> > > For node-notifier, which is also a dev dependency, I am not sure how
> > > it is used in dubbo-admin. But I tried to remove it and build it,
> > > everything looks good. I think it can be removed.
> >
> > That would be best I think.
> >
> > Thanks,
> > Justin
>
>
>
> --
> Best Regards！
> Huxing
>
