I see. It's fine, let's watch out for each other and avoid of accidental mistake :)
Regards, -Ian. On Thu, Mar 28, 2019 at 1:20 AM Taosheng, Wei <[email protected]> wrote: > Hi, > I have deleted the branch. And I remember why this happened. At the > beginning, I tried to revert the pr 3688, so I click the "revert" button of > github. And the github should created a branch on the main repo, but I > didn't find it. And then I didn't want to revert the pr, so I closed the > revert pr. But the branch created by github automatically was remained. > So I just want to remind that we should be careful when we need to revert > one pr. Remembering that the revert function provided by github will create > a branch on the main repo. > > > > > ------------------ Original ------------------ > From: "Taosheng, Wei"<[email protected]>; > Date: Wed, Mar 27, 2019 11:03 PM > To: "dev"<[email protected]>;"dev"<[email protected]>; > > Subject: Re: never create branch on main repo > > > > hi Ian, > I am so sorry to make the mistake. I just wanted to submit a pr, but it > make a mistaken operation of creating a branch. I will be more careful when > trying to submit a pr. > > > ------------------ Original ------------------ > From: Ian Luo <[email protected]> > Date: Tue,Mar 26,2019 5:45 PM > To: dev <[email protected]> > Subject: Re: never create branch on main repo > > > > Hi Folks, > > Recently I noticed there's a branch named > 'revert-3688-config-center-config' created on the main repo. This is > unacceptable even if you are granted with the committer privilege. > > Pls. **ALWAYS** go through pull request unless you are working on release. > > Thanks, > -Ian.
