Hi,
On Sat, Mar 30, 2019 at 6:36 AM Hen <[email protected]> wrote: > > On Thu, Mar 28, 2019 at 7:58 AM Huxing Zhang <[email protected]> wrote: > > > Hi, > > > > > > On Thu, Mar 28, 2019 at 6:41 PM Justin Mclean <[email protected]> > > wrote: > > > > > > Hi, > > > > > > >> * the test file would not show up when an Apache Dubbo user uses > > Dubbo 'in production'? > > > > > > > > No, they won't show up when use in production, either a user compile > > > > from source code or download the binary distribution. > > > > > > Sadly this is not the case. In unzipped src distribution if I run `mvn > > compile` and then do this `find . -name "idleness.txt”` I get this result: > > > > > > ./dubbo-admin-ui/node_modules/wordwrap/test/idleness.txt > > > > > ./dubbo-admin-ui/node_modules/cliui/node_modules/wordwrap/test/idleness.txt > > > > Those are just intermediate files, but they don't go into executable > > binaries. > > > > It sounds like that fails my question of: > > "* the test file would not be in the download for Apache Dubbo (and > presumably other typical use cases)?" The test file will be downloaded when user compile the software from source code. > > Circling back, my feeling was that if the following three items are true, > then we continue to depend on these projects and encourage them to fix the > problem, reviewing the subject in the future if they stop trying to fix it; > > 1) Apache do not distribute idleness.txt. By meaning distribute, do you think the behavior that when user compile the Apache Dubbo Admin project from source code, the idleness.txt gets downloaded, is sort of distributing idleness.txt? > 2) Apache do not have idleness.txt in our source control. This is doubtlessly true. > 3) The use of Apache Dubbo does not mean our users are copying idleness.txt > into their products (be that production server, app etc.) If the users just use the compiled Apache Dubbo Admin binaries. They are not copying idleness.txt. If the users include the source code of Apache Dubbo Admin into their project, say project A, when user install the project A, the idleness.txt file may be downloaded as well. Do you think this violates your condition number 3? > > Hen Actually the community is discussing a work around that remove the dependency to eslint. I am just curiously to know how it is being viewed from legal perspective. Sorry English is not my native language, so I may not understand it very accurately. Another issue is, if at the end the conditions are not met, what should we do next. Dubbo Admin previously did a release which has the same issue, but at that time this issue was not identified. Other ASF project may also be affected, should we notify them about this issue? -- Best Regards！ Huxing
