Hi, I agree with Ian. I think small patches to polish code is acceptable. People these days are getting busy, and might not have large amount of time to contribute. Meanwhile, the it is easy to review. Large size pull request can be hard to review.
On Tue, Apr 9, 2019 at 10:31 AM yuhang xiu <[email protected]> wrote: > > Hi, all > > Recently I found out that we have merged some pull requests for the polish > code. > > I personally do not advocate small-scale polish code, such as this pr [1]. > We can't see the improvement clearly. > > I think that for this pr, we should put it in a large-scale polish code, or > bugfix and feature-related pr, rather than separate. > > It's important to note that I am not denying the importance of the polish > code. I just think that these prs will disrupt our commits record. > > I have encountered this problem in the flink community. The flink community > does not accept small-scale polish code pr. They suggested that this change > should be placed in other prs. > > What do you think about this? > > [1] https://github.com/apache/incubator-dubbo/pull/3820/files -- Best Regards！ Huxing
