I took a brief look at your pull request. It looks good to me. -Ian.
On Wed, Apr 10, 2019 at 10:10 AM YunKun Huang <[email protected]> wrote: > hey, > > As discussed in > https://lists.apache.org/thread.html/ce643df597ddfa45624316768c0914a7bd16b10f0e773d03a271775d@%3Cdev.dubbo.apache.org%3E, > there are many requirements for official docker image for dubbo-admin. > Infra team helped us to prepare a dockerhub repo under apache account. > This is the link: https://hub.docker.com/r/apache/dubbo-admin > > We have two option to release publish docker image: > > + someone build docker image and push to dockerhub > + put dockerfile in github repo[1] and use dockerhub autobuild to generate > image > > My personal idea is use second option, because it's easy to track and > verify docker image; This not require any manual work when publish new > image. we just need add a new autobuild rule and trigger build. > > For the version, as Justin suggested, only released version will be > published which means for now we have version 0.1.0 and 0.2.0.For latest > version, it will point to 0.2.0. > > About release process, I suggest we include docker image release as part > of release process, once new version is released and marked in github, we > will add a new rule to generate new version of docker image. > > How do you think? any suggestion? > > [1] https://github.com/apache/incubator-dubbo-admin/pull/357 > > >
