Hi, -1 (binding) due to binaries in source release and unknown license issues
It’s a good idea to put [VOTE]” is the subject title so people know it’s a vote and to give the artifacts a release candidate name. e.g. RC1, RC2 etc so it doesn’t become confusing release candidate which you are voting on. I checked: - signatures and hashes correct - LICENSE and NOTICE exist - I think 3rd party license information is missing from LICENSE - A large number of source files are missing ASF headers e.g. [1][2] - There are unexpected binaries in the source release [3][4][5][6]. ASF release sneed to consist of source code and contain no compiled code. LICENSE seem to be missing included 3rd party licensed code. For instance there are a number of files with "Copyright 1999-2011 Alibaba Group.” e.g [7][8]. That second file seem to come from here [9] and is MIT licensed so this file also has the incorrect header. This is code form here [10] of unknown license. These files [11][12][13] seem to have a different author, how are they licensed? As do these two files [14][15] which seem to come from here [16] and I’m not sure of their license. There’s a minor issue with LICENSE in that it should not include "Copyright (c) 2016 ~ 2018 Alex Stocks." Thanks, Justin 1. dubbo-go-1.1.0/cluster/loadbalance/least_active_test.go 2. dubbo-go-1.1.0/examples/dubbo/go-client/assembly/common/build.sh 3. dubbo-go-1.1.0/config_center/zookeeper/zookeeper-4unitest/contrib/fatjar/zookeeper-3.4.9-fatjar.jar 4. dubbo-go-1.1.0/registry/zookeeper/zookeeper-4unitest/contrib/fatjar/zookeeper-3.4.9-fatjar.jar 5. dubbo-go-1.1.0/remoting/zookeeper/zookeeper-4unitest/contrib/fatjar/zookeeper-3.4.9-fatjar.jar 6. dubbo-go-1.1.0/examples/dubbo/go-server/app/app 7. ./examples/jsonrpc/java-client/src/main/resources/META-INF/spring/service.xml 8. ./examples/jsonrpc/java-client/src/main/java/com/ikurento/user/UserProvider.java 9. https://github.com/JoeCao/dubbo_jsonrpc_example/ 10. http://big-elephants.com/2016-12/fasthttp-client/ 11../cluster/loadbalance/least_active.go 12 ./protocol/RpcStatus.go 13../filter/impl/active_filter.go 14. ./examples/jsonrpc/java-client/src/main/java/com/ikurento/user/Consumer.java 15../examples/dubbo/java-client/src/main/java/com/ikurento/user/Consumer.java 16. https://github.com/baozh?tab=repositories
