thanks Justin, let me fix it.

Justin Mclean <[email protected]> 于2019年11月17日周日 上午5:34写道:

> Hi,
>
> -1 (binding) as the release need to be cryptographically signed, it's
> missing LICENSE and NOTICE files and missing some ASF headers.
>
> I checked:
> - hash is fine
> - missing signature
> - missing LICENSE and NOTICE files
> - files are missing ASF headers e.g. [1][2][3][4] and others
> - no unexpected binary files which is good
> - unable to compile from source
>
> Having some instruction in the README on how to compile the source release
> woful be useful. I tried several think but was unable to do so.
>
> Thanks,
> Justin
>
> 1. ./dubbo/src/__tests__/byte-test.ts
> 2 ./dubbo/src/__tests__/dubbo-url-test.ts
> 3. ./dubbo/src/__tests__/dubbox-test.ts
> 4. dubbo/src/__tests__/socket-worker-test.ts

Reply via email to