Hi, I am canceling this vote, please vote on the RC2 thread.
Jun > On Dec 23, 2019, at 12:17 PM, jun liu <[email protected]> wrote: > > Thanks you all for voting, but I am afraid we have to restart a new vote > after fixed the following issue relating to gRPC protocol support. > > https://github.com/apache/dubbo/issues/5511 > > Jun > >> On Dec 21, 2019, at 7:37 PM, YunKun Huang <[email protected]> wrote: >> >> Hi, >> >> [x] +0 no opinion >> >> I have checked: >> Can compile from source >> Unit test pass >> LICENSE and NOTICE file exist >> >> I vote for +0, because this RC is ok with checklist, but I have concern for >> usage with @PostConstruct. >> Dubbo-common modules are using @PostConstruct [1], this annotation is >> removed in java 11 and it's implement by third party library, >> which means application may fail in any jdk higher than jdk8. it may >> doesn't work if there is no library or code implement this annonation. >> if we still want to do this, we need highlight this risk in release note or >> README file >> >> [1] >> https://github.com/apache/dubbo/blob/master/dubbo-common/src/main/java/org/apache/dubbo/config/AbstractConfig.java#L588 >> >> >> On Fri, Dec 20, 2019 at 1:22 PM Justin Mclean <[email protected]> >> wrote: >> >>> Hi, >>> >>> +1 (binding) >>> >>> I checked: >>> - signatures and hashes fine >>> - LICENSE and NOICE file >>> - Files have ASF headers except a couple like [1] >>> - No unexpected binary files >>> - Can compile from source >>> >>> Thanks, >>> Justin >>> >>> >>> [1] ./compiler/src/main/resources/DubboGrpcStub.mustache >>> >
