>> The issues pointed by Justin and Yunkun during RC1 vote are not included. > > Why is that? Issues once know should be fixed in the next RC. Issues once > know and not corrected warrant a -1 vote IMO. Your not an incubating project > anymore but a top level one and need to follow ASF p[policy.
Yes, we should have fixed them in RC2. The reason we didn’t do that is only that I forgot the License issue when packaging. It was not until I came back to the mailing-list that I realized that this issue exists, so I put them in the voting mail to remind voters of the existing issues. Since it’s not too much work, let me start a new voting thread to fix them. * Files have ASF headers except a couple like — should be fixed. * Dubbo-common modules are using @PostConstruct — it’s a design of Dubbo’s feature, discuss and make the decision in the future. Jun > On Dec 23, 2019, at 7:41 PM, Justin Mclean <[email protected]> wrote: > > Hi, > >> The issues pointed by Justin and Yunkun during RC1 vote are not included. > > Why is that? Issues once know should be fixed in the next RC. Issues once > know and not corrected warrant a -1 vote IMO. Your not an incubating project > anymore but a top level one and need to follow ASF p[policy. > > Thanks, > Justin > >
