Thank you, those links will be removed in the next release. Kind regards, Mercy Ma
On Fri, Jan 3, 2020 at 8:04 AM Justin Mclean <[email protected]> wrote: > Hi, > > +1 but there’s an issue need to be fixed in the next release. All files > are apache licensed so there no license issue per say. > > I checked: > - signatures and hashes fine > - LICENSE is missing one file [1] > - NOTICE year need updating > - This file seems to incorrectly have an ASF header [1] when it from > another project. > - No unexpected binary files > - can compile from source > > Some of the documentation still refers to https://github.com/dubbo and > https://github.com/mercyblitz this will need to change. This was brought > up in a previous release when will this be fixed? > > Thanks, > Justin > > > 1. > ./dubbo-spring-boot-samples/dubbo-registry-zookeeper-samples/provider-sample/src/main/java/org/apache/dubbo/spring/boot/demo/provider/bootstrap/EmbeddedZooKeeper.java > > -- *Mercy Ma* GMail:[email protected] Yahoo: [email protected] Wetchat: mercyblitz-1985 Twitter : @mercyblitz <http://twitter.com/mercyblitz> Blog : https://mercyblitz.github.io/
