Hi,

-1 (binding) Why was the license and notice changed from the last RC?

I checked:
- LICENSE include dependancies rather than bundled software. Only things 
included in the release need to be mentioned in LICENSE.
- If those MIT likened bit of code were included then you would need to include 
the MIT license for each one. The MIT license include a copyright line making 
it different for each project.
- NOTICE has incorrect year (2019)
- NOTICE incorrectly contains license information
- No unexpected binary files
- All files have ASF headers
- Can compile from source


Other minor issues:
- your code of conduct should point to the Apache wide one.

Thanks,
Justin

Reply via email to