Hi,

+1 binding but there a couple of minor issue that need to be fixed before next 
release

I checked:
- signatures and hashes are OK
- The LICENSE is missing the appendix and one copyright owner
- the year in NOTICE is incorrect
- all source files have ASF headers
- no unexpected binary files
- didn’t compile from source. The instruction on how to do this cruel be 
clearer in the readme.

License is missing the license/copyright owner of this file [1]

It would be better to sign with an apache.org signature rather than a gmail one.

Thanks,
Justin

1. ./protocol/grpc/protoc-gen-dubbo/examples/helloworld.proto

Reply via email to