Thanks,we will fix them. Justin Mclean <jus...@classsoftware.com> 于2020年2月12日周三 上午10:03写道:
> Hi, > > +1 binding but there a minor issue mentioned before that was not fixed. > > I checked: > - signatures and hashes are OK > - The LICENSE imisisng mention of [1] > - NOTICE is correct > - all source files have ASF headers (except [1]) > - no unexpected binary files > - Again didn’t compile from source. The instruction on how to do this > could be clearer in the readme. > > Thanks, > Justin > > 1. ./protocol/grpc/protoc-gen-dubbo/examples/helloworld.proto