I checked the following items. I vote +1 (binding) to this release.
[v] Are release files in correct location?
[v] Are the digital signature and hashes correct?
[v] Do LICENSE and NOTICE files exists?
[v] Is the LICENSE and NOTICE text correct?
[v] Is the NOTICE year correct?
[x] Un-included software dependencies are not mentioned in LICENSE or
NOTICE?
[x] License information is not mentioned in NOTICE?
[x] Is there any 3rd party code contained inside the release? If so:
[ ] Does the software have a compatible license?
[ ] Are all software licenses mentioned in LICENSE?
[ ] Is the full text of the licenses (or pointers to it) in LICENSE?
Is any of this code Apache licensed? Do they have NOTICE files? If so:
[ ] Have relevant parts of those NOTICE files been added to this NOTICE
file?
[ ] Do all source files have ASF headers?
[v] Do the contents of the release match with what's tagged in version
control?
[x] Are there any unexpected binary files in the release?
[v] Can you compile from source? Are the instruction clear?
I vote with:
[v] +1 release the software
[ ] +0 not sure if it should be released
[ ] -1 don’t release the software because..
Regards,
-Ian.
On Fri, Mar 6, 2020 at 4:04 PM 望哥 <[email protected]> wrote:
> Hello Dubbo/Dubbogo Community,
>
> This is a call for vote to release Apache dubbo-go-hessian2 version v1.4.0
> RC1.
>
> The release candidates:
> https://dist.apache.org/repos/dist/dev/dubbo/dubbo-go-hessian2/v1.4.0-rc1/
> Git tag for the release:
> https://github.com/apache/dubbo-go-hessian2/tree/1.4
> Hash for the release tag: 4c31e88c35afe84c0321d9f12f036e6d3c8962d0
> Release Notes:
> https://github.com/apache/dubbo-go-hessian2/blob/1.4/CHANGE.md
> The artifacts have been signed with Key :7DB68550D366E4C0, which can be
> found in the keys file:
> https://dist.apache.org/repos/dist/dev/dubbo/KEYS
>
> The vote will be open for at least 72 hours or until necessary number of
> votes are reached.
>
> Please vote accordingly:
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove with the reason
>
> Thanks,
> The Apache Dubbo-go Team
>
