I double checked and echo Justin's vote. In order to avoid this from happening again, I believe we should make sure it's guarded by tooling, like dubbo java project does [1]. I filed an issue [2] to track this.
Regards, -Ian. 1. https://github.com/apache/dubbo/blob/master/licenseCheck.sh 2. https://github.com/apache/dubbo-go/issues/435 On Fri, Mar 20, 2020 at 11:39 AM Justin Mclean <[email protected]> wrote: > Hi, > > Sorry but it’s -1 binding form me as there are files missing ASF headers > or 3rd party code of unknown licensing in the release > > I checked: > - signatures and hashes are fine > - LICENSE and NOTICE are fine > - no unexpected bins art files > - source files are missing ASF headers [1][2][3][4] > - can compile from source > > Thanks, > Justin > > > 1. dubbo-go-v1.4.0/common/extension/auth.go > 2. dubbo-go-v1.4.0/config/interfaces/config_reader.go > 3. dubbo-go-v1.4.0/filter/filter_impl/active_filter_test.go > 4. dubbo-go-v1.4.0/protocol/rpc_status_test.go > > >
