Hi, Justin > The NOTICE file doesn’t need to mention that unless headers have been removed from any files that come from Caucho Hessian, for that to happen we would need a software grant.
I know that the NOTICE file is still missing. Actually, I added NOTICE file to the project before packaging, but after I did that I found that the NOTICE file doesn't have anything to mention but the following lines: Apache Dubbo Copyright 2018-2020 The Apache Software Foundation This product includes software developed at The Apache Software Foundation (http://www.apache.org/). Since all the Caucho Hessian files have the original headers, I thought we can add NOTICE when necessary, so I finally removed it. Maybe I need to check the related Apache clauses to find out why we need the NOTICE file. On Sat, Mar 28, 2020 at 6:22 AM Justin Mclean <[email protected]> wrote: > Hi, > > -1 (binding) The NOTICE file is still missing, everything else looks good. > > Thanks, > Justin >
