zouyx commented on a change in pull request #476:
URL: https://github.com/apache/dubbo-go/pull/476#discussion_r413721851
##########
File path: config/service_config.go
##########
@@ -123,10 +134,12 @@ func (c *ServiceConfig) Export() error {
regUrls := loadRegistries(c.Registry, providerConfig.Registries,
common.PROVIDER)
urlMap := c.getUrlMap()
protocolConfigs := loadProtocol(c.Protocol, providerConfig.Protocols)
- if len(protocolConfigs) == 0 {
+ protocolSize := len(protocolConfigs)
+ if protocolSize == 0 {
logger.Warnf("The service %v's '%v' protocols don't has right
protocolConfigs ", c.InterfaceName, c.Protocol)
Review comment:
```protocolSize``` will use in following code before - -
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
