AlexStocks commented on a change in pull request #476:
URL: https://github.com/apache/dubbo-go/pull/476#discussion_r416336356
##########
File path: config/service_config.go
##########
@@ -116,11 +116,13 @@ func getRandomPort(protocolConfigs []*ProtocolConfig)
*list.List {
}
tcp, err := gxnet.ListenOnTCPRandomPort(proto.Ip)
+ if tcp != nil {
Review comment:
老何坑你,你不能 argue 下啊。这代码也太 ugly 了。
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]