> but I found the unit test failed for some reason. @Jun Liu > <mailto:[email protected]> You should check the unit test.
The UT failed because of one binary file is not packed into the source package. We need to catch the potential exceptions in the next time. Jun > On Jul 23, 2020, at 9:56 AM, victory <[email protected]> wrote: > > +1 (binding) > > - signatures and hashes are fine > - LICENSE and NOTICE good > - compile fine > > but I found the unit test failed for some reason. @Jun Liu > <mailto:[email protected]> You should check the unit test. > > Ian Luo <[email protected] <mailto:[email protected]>> 于2020年7月22日周三 > 下午10:03写道： > I checked the following items. I vote +1 (binding) to this release. > > [v] Are release files in correct location? > [v] Are the digital signature and hashes correct? > [v] Do LICENSE and NOTICE files exists? > [v] Is the LICENSE and NOTICE text correct? > [v] Is the NOTICE year correct? > [x] Un-included software dependencies are not mentioned in LICENSE or > NOTICE? > [x] License information is not mentioned in NOTICE? > [v] Do the contents of the release match with what's tagged in version > control? > [x] Are there any unexpected binary files in the release? > [v] Can you compile from source? Are the instruction clear? > > I vote with: > [v] +1 release the software > [ ] +0 not sure if it should be released > [ ] -1 don’t release the software because.. > > Regards, > -Ian. > > On Fri, Jul 17, 2020 at 2:15 PM Jun Liu <[email protected] > <mailto:[email protected]>> wrote: > > > Hello Dubbo Community, > > > > This is a call for vote to release Apache Dubbo version 2.6.9. > > > > The release candidates: > > https://dist.apache.org/repos/dist/dev/dubbo/dubbo/2.6.9/ > > <https://dist.apache.org/repos/dist/dev/dubbo/dubbo/2.6.9/> > > > > Git tag for the release: > > https://github.com/apache/dubbo/releases/tag/dubbo-2.6.9 > > <https://github.com/apache/dubbo/releases/tag/dubbo-2.6.9> > > > > Hash for the release tag: > > d895bf15d0dda6a69c552c6b06d5e452692bef53 > > > > Release Notes: > > https://github.com/apache/dubbo/releases/tag/dubbo-2.6.9 > > <https://github.com/apache/dubbo/releases/tag/dubbo-2.6.9> > > > > The artifacts have been signed with Key: 28681CB1, which can be found in > > the keys file: > > https://dist.apache.org/repos/dist/dev/dubbo/KEYS > > <https://dist.apache.org/repos/dist/dev/dubbo/KEYS> > > > > The vote will be open for at least 72 hours or until necessary number of > > votes are reached. > > > > Please vote accordingly: > > > > [ ] +1 approve > > [ ] +0 no opinion > > [ ] -1 disapprove with the reason > > > > Thanks, > > The Apache Dubbo Team > > > > > > > -- > > Best Regard! > cvitory
