I think it's ok to move it out. But I would like to know if its possible to include samples in dubbo-go instead of dubbo-go-samples？
its more easy to maintain samples with dubbo-go together and manage with versioning On Wed, Sep 30, 2020 at 6:20 PM Ian Luo <[email protected]> wrote: > +1 to approve. > > On Tue, Sep 29, 2020 at 12:13 AM joezou <[email protected]> wrote: > > > Hello Dubbo/Dubbogo Community, > > > > This is a call for a vote to move dubbo-go samples[1] out of > > dubbo-samples[2] , migrate to a new project which is called > > dubbo-go-samples. > > > > Now dubbo-samples include java and golang samples.For samples is great > ,but > > it is not good for managing integration testing for both versions. > > > > Besides we want to add integration testing based on dubbo-go-samples from > > now on ,but dubbo-samples[2] of java took a long time for integration > > testing each time, close to 30 minutes [3]. Now more than 20 golang > > samples, if take 1 minute for a sample, expect more than 20 minutes. > > > > So we want to be independent of dubbo-samples. > > > > > > [1]:https://github.com/apache/dubbo-samples/tree/master/golang > > [2]:https://github.com/apache/dubbo-samples > > [3]:https://travis-ci.org/github/apache/dubbo-samples/builds/730989552 > > > > Please vote accordingly: > > > > [ ] +1 approve > > [ ] +0 no opinion > > [ ] -1 disapprove with the reason > > > > Thanks, > > The Apache Dubbo Team > > >
