+1 approve. I checked: - sha512 hashes and signatures are good - all uts passed
However, some improvements need to be made. 1 Pls check the second import block of common/proxy/proxy_test.go and improve it. joezou <[email protected]> 于2020年9月27日周日 上午9:45写道： > Hello Dubbo/Dubbogo Community, > > This is a call for vote to release Apache dubbo-go version v1.5.2-rc1. > > The release candidates: > https://dist.apache.org/repos/dist/dev/dubbo/dubbo-go/v1.5.2-rc1/ > > Git tag for the release: > https://github.com/apache/dubbo-go/releases/tag/v1.5.2-rc1 > > Hash for the release tag: 2f1d1e50390a06f4f63c783adfd40be235987159 > > Release Notes: https://github.com/apache/dubbo-go/blob/1.5/CHANGE.md > > The artifacts have been signed with Key :4B87D4B65EEFB515, which can be > found in the keys file: https://dist.apache.org/repos/dist/dev/dubbo/KEYS > > The vote will be open for at least 72 hours or until necessary number of > votes are reached. > > Please vote accordingly: > [ ] +1 approve > [ ] +0 no opinion > [ ] -1 disapprove with the reason > > Thanks, > The Apache Dubbo-go Team >
