+1 approve.

I checked
[√] all uts passed
[√] CHANGE.md
[√] licence

stocks alex <[email protected]> 于2021年1月9日周六 下午4:57写道:

> +1 approve.
>
> Some lint errors should be fixed as follows.
>
> 1 the date time range should be "2018-2021" instead of "2018-2020";
> 2 the var name should be "cluster" instead of "cluser" on
> cluster/cluster_impl/available_cluster.go line 42;
> 3 the version should be "1.5.5" in common/constant/version.go. the date
> should be changed too.
> 4 attahments1 -> attachments1 in common/proxy/proxy_test.go line 134.
> 5 multiConfiger -> multiConfigures in config/base_config.go line 36.
> 6 Verison -> Version config_center/configurator/override_test.go.
> 7 DEFAULT_REVIESION -> DEFAULT_REVISION  common/constant/default.go
> 8 dailOpts -> dialOpts in protocol/grpc/client.go;
> 9 serviceDiscovry -> serviceDiscovery in
> registry/nacos/service_discovery_test.go.
> 10 requst -> request in remoting/exchange.go.
>
> joezou <[email protected]> 于2021年1月5日周二 下午10:40写道:
>
> > Hello Dubbo/Dubbogo Community,
> >
> >   This is a call for vote to release Apache dubbo-go version v1.5.5.
> >
> >   The release candidates:
> > https://dist.apache.org/repos/dist/dev/dubbo/dubbo-go/v1.5.5/
> >
> >   Git tag for the release:
> > https://github.com/apache/dubbo-go/releases/tag/v1.5.5
> >
> >   Hash for the release tag: 111abaa7064ee1377d3816b3dfe3203f743fae08
> >
> >   Release Notes: https://github.com/apache/dubbo-go/blob/1.5/CHANGE.md
> >
> >   The artifacts have been signed with Key :4B87D4B65EEFB515, which can be
> > found in the keys file:
> https://dist.apache.org/repos/dist/dev/dubbo/KEYS
> >
> >   The vote will be open for at least 72 hours or until necessary number
> of
> > votes are reached.
> >
> >  Please vote accordingly:
> >  [ ] +1 approve
> >  [ ] +0 no opinion
> >  [ ] -1 disapprove with the reason
> >
> >  Thanks,
> >  The Apache Dubbo-go Team
> >
>

Reply via email to