>> - dubbo-samples-metadata-report-local-xml: there is a NPE situation
>> occurred when `serviceDiscoveryInvoker` is NULL in


I’ve merged the NPE patch[1] into 2.7.9-release but this sample still fails, I 
didn’t find the root reason yet. But it’s more likely the sample's problem.

>> - dubbo-samples-zipkin: due to the default behavior changed in
>> `spring-context-support`.

Fixed by merging this patch[2]

>> - dubbo-samples-tengine: due to the 2.7.9 version of
>> dubbo-spring-boot-starter has not yet been released, and we can ignore it
>> now

Fixed by using the fixed latest starter release[3]

1. https://github.com/apache/dubbo/pull/7133
2. https://github.com/apache/dubbo/pull/7145
3. https://github.com/apache/dubbo-samples/pull/276

Jun

> On Feb 5, 2021, at 11:59 PM, Jun Liu <[email protected]> wrote:
> 
> 
>> - dubbo-samples-tengine: due to the 2.7.9 version of
>> dubbo-spring-boot-starter has not yet been released, and we can ignore it
>> now
>> - dubbo-samples-metadata-report-local-xml: there is a NPE situation
>> occurred when `serviceDiscoveryInvoker` is NULL in
>> `org.apache.dubbo.registry.integration.InterfaceCompatibleRegistryProtocol$MigrationInvoker.isAvailable(InterfaceCompatibleRegistryProtocol.java:152)`[2]
>> - dubbo-samples-zipkin: due to the default behavior changed in
>> `spring-context-support`.
>> You can find detailed information in apache/dubbo-samples#272[3].
> 
> I will check the details
> 
> Jun
> 
>> On Feb 5, 2021, at 10:45 PM, Albumen Kevin <[email protected]> wrote:
>> 
>> Hi,
>> 
>> I vote -0 non-binding
>> 
>> I think this version is not suitable for release, because I have found two
>> bugs still exist in this version.
>> 
>> According to Github Actions[1], during integration testing, there were
>> three test cases failed.
>> 
>> - dubbo-samples-tengine: due to the 2.7.9 version of
>> dubbo-spring-boot-starter has not yet been released, and we can ignore it
>> now
>> - dubbo-samples-metadata-report-local-xml: there is a NPE situation
>> occurred when `serviceDiscoveryInvoker` is NULL in
>> `org.apache.dubbo.registry.integration.InterfaceCompatibleRegistryProtocol$MigrationInvoker.isAvailable(InterfaceCompatibleRegistryProtocol.java:152)`[2]
>> - dubbo-samples-zipkin: due to the default behavior changed in
>> `spring-context-support`.
>> You can find detailed information in apache/dubbo-samples#272[3].
>> 
>> [1] https://github.com/apache/dubbo/runs/1838946780
>> [2]
>> https://github.com/apache/dubbo/blob/73264fbe30b7a33d620cd3cc2f2d48f1135c68f8/dubbo-registry/dubbo-registry-api/src/main/java/org/apache/dubbo/registry/integration/InterfaceCompatibleRegistryProtocol.java#L152
>> [3] https://github.com/apache/dubbo-samples/issues/272
>> 
>> Thanks,
>> Albumen
>> 
>> On Fri, Feb 5, 2021 at 9:09 PM Jun Liu <[email protected]> wrote:
>> 
>>> Hello Community,
>>> 
>>> This is a call for vote to release Apache Dubbo version 2.7.9
>>> 
>>> The release candidates:
>>> https://dist.apache.org/repos/dist/dev/dubbo/dubbo/2.7.9/
>>> 
>>> Git tag for the release:
>>> https://github.com/apache/dubbo/tree/dubbo-2.7.9
>>> 
>>> Hash for the release tag:
>>> 73264fbe30b7a33d620cd3cc2f2d48f1135c68f8
>>> 
>>> Release Notes:
>>> https://github.com/apache/dubbo/releases/tag/dubbo-2.7.9
>>> 
>>> The artifacts have been signed with Key 28681CB1, which can be
>>> found in the keys file:
>>> https://dist.apache.org/repos/dist/dev/dubbo/KEYS
>>> 
>>> The vote will be open for at least 72 hours or until necessary number of
>>> votes are reached.
>>> 
>>> Please vote accordingly:
>>> 
>>> [ ] +1 approve
>>> [ ] +0 no opinion
>>> [ ] -1 disapprove with the reason
>>> 
>>> Thanks,
>>> The Apache Dubbo Team
>>> 
> 

Reply via email to