+1 approve. however, there are slight errors need to be fixed.
1 const.go line 34: the comment word constants should be constants. 2 hessian.go line 41: add clearly comment for PackageType. 3 ref.go line 30: the name of _refElem should be changed as I have not seen other words begin with "_" in goland src codes. wongoo <[email protected]> 于2021年3月14日周日 下午10:44写道： > Hello Dubbo/Dubbogo Community, > > This is a call for a vote to release Apache dubbo-go-hessian2 version > v1.9.0 RC1. > > The release candidates: > https://dist.apache.org/repos/dist/dev/dubbo/dubbo-go-hessian2/v1.9.0-rc1/ > Git tag for the release: > https://github.com/apache/dubbo-go-hessian2/tree/1.9 > Hash for the release tag: d829b56bf3e56a2f424ef4555eb15ec8b131b3c9 > Release Notes: > https://github.com/apache/dubbo-go-hessian2/blob/1.9/CHANGE.md > The artifacts have been signed with Key :7DB68550D366E4C0, which can be > found in the keys file: > https://dist.apache.org/repos/dist/dev/dubbo/KEYS > > The vote will be open for at least 72 hours or until a necessary number of > votes are reached. > > Please vote accordingly: > [ ] +1 approve > [ ] +0 no opinion > [ ] -1 disapprove with the reason > > Thanks, > The Apache Dubbo-go Team >
