+1(binding) to approve this release. As usual, I have checked the following
items:
[v] Are release files in correct location?
[v] Are the digital signature and hashes correct?
[v] Do LICENSE and NOTICE files exists?
[v] Is the LICENSE and NOTICE text correct?
[v] Is the NOTICE year correct?
[x] Un-included software dependencies are not mentioned in LICENSE or
NOTICE?
[x] License information is not mentioned in NOTICE?
[v] Do the contents of the release match with what's tagged in version
control?
[x] Are there any unexpected binary files in the release?
Howver, @Laurance, pls checks the following questions.
* 1 the shorter receiver name of AttachmentMatchJudger in
router/v3router/judger/attachment_match_judger.go should not be 'amj'. Just
one character should be enough. The same problem exists in the following
items too.
router/v3router/judger/bool_match_judger.go BoolMathJudger
router/v3router/judger/double_match_judger.go DoubleMatchJudger
router/v3router/judger/double_range_match_judger.go DoubleRangeMatchJudger
router/v3router/judger/list_double_match_judger.go ListDoubleMatchJudger
router/v3router/judger/list_string_match_judger.go ListStringMatchJudger
router/v3router/judger/method_match_judger.go MethodMatchJudger
router/v3router/judger/string_match_judger.go StringMatchJudger
router/v3router/dubbo_rule.go DubboRouterRule
Pls fix this problem in the following publish edition.
joezou <[email protected]> 于2021年6月24日周四 上午12:23写道：
> +1 binding
>
> Checked
> [√] All uts passed.
> [√] CHANGE.md .
> [√] License headers .
> [√] Download links are fine.
>
> Laurence <[email protected]> 于2021年6月21日周一 上午11:58写道：
>
> > Hello Dubbo/Dubbogo Community,
> >
> > This is a call for vote to release Apache dubbo-go version v3.0.0-rc2.
> >
> > The release candidates:
> > https://dist.apache.org/repos/dist/dev/dubbo/dubbo-go/v3.0.0-rc2/
> >
> > Git tag for the
> > release:https://github.com/apache/dubbo-go/releases/tag/v3.0.0-rc2
> >
> > Hash for the release tag: ca2a46f8dfb22e1c02fbfe2a3695356429525d09
> >
> > Release Notes:
> https://github.com/apache/dubbo-go/blob/3.0/CHANGELOG.md
> >
> > The artifacts have been signed with Key : 9E35BEAEF085ED25, which can
> be
> > found in the keys file:
> https://dist.apache.org/repos/dist/dev/dubbo/KEYS
> >
> > The vote will be open for at least 72 hours or until necessary number
> of
> > votes are reached.
> >
> >
> > Please vote accordingly:
> > [ ] +1 approve
> > [ ] +0 no opinion
> > [ ] -1 disapprove with the reason
> >
> > Thanks,
> > The Apache Dubbo-go Team
> >
>
