+1 binding, I checked
[√ ] Do the contents of the release match with what's tagged in version control? [√ ] Are there any unexpected binary files in the release? [√ ] Do LICENSE and NOTICE files exist? [√ ] Is the LICENSE and NOTICE text correct? [√ ] Are release files in the correct location? [√ ] Are the digital signatures and hashes correct? [√ ] the NOTICE year correct [√ ] Can you compile from source? Are the instructions clear? [√ ] All uts pass On Tue, Aug 10, 2021 at 11:37 PM feng hu <[email protected]> wrote: > Hi Justin Mclean, > > The problem has been fixed, svn had committed the latest package. > > Kind Regards, > hufeng > > feng hu <[email protected]> 于2021年8月10日周二 下午6:23写道： > > > Hi, > > > > Thanks for helping check, let me fix these problems > > > > Kind Regards, > > hufeng > > > > Justin Mclean <[email protected]> 于2021年8月10日周二 下午3:36写道： > > > >> Hi, > >> > >> Sorry it’s -1 (binding) from me. > >> > >> I think you might want to repackage the release as it unpacks to > >> "Users/hufeng/Desktop/“ > >> > >> I checked: > >> - signature and hashes are fine > >> - LICENSE is missing some information or some files have the wrong > headers > >> - NOTICE is a little ahead of itself (2022!) > >> - A number of files have "Copyright 1999-2018 Alibaba Group Holding > Ltd.” > >> in their header, either this is incorrect or something is missing from > >> LICENSE. This files also seem to have double headers. > >> - No unexpected binary files > >> > >> Kind Regards, > >> Justin > > > > >
