+1 binding Checked [√] All uts passed. [√] CHANGE.md . [√] License headers . [√] Download links are fine. [√] The LICENSE and NOTICE text is correct. [√] The NOTICE year is correct.
stocks alex <[email protected]> 于2021年10月24日周日 下午5:22写道： > +1(binding) to approve this release. As usual, I have checked the following > items: > > [v] Are release files in correct location? > [v] Are the digital signature and hashes correct? > [v] Do LICENSE and NOTICE files exists? > [v] Is the LICENSE and NOTICE text correct? > [v] Is the NOTICE year correct? > [x] License information is not mentioned in NOTICE? > [v] Do the contents of the release match with what's tagged in version > control? > > However, the following two check items are not right. > > [] Un-included software dependencies are not mentioned in LICENSE or > NOTICE? > [] Are there any unexpected binary files in the release? > > There are two "zookeeper-3.4.9-fatjar.jar" in this release package for ut. > > Please delete them. > > joezou <[email protected]> 于2021年10月20日周三 下午3:47写道： > > > +1 binding > > > > Checked > > [√] All uts passed. > > [√] CHANGE.md . > > [√] License headers . > > [√] Download links are fine. > > > > BTW，you should use release page[1] in Git tag for the release. > > > > [1]:https://github.com/apache/dubbo-go-pixiu/releases/tag/v0.4.0-rc1 > > > > ztelur <[email protected]> 于2021年10月20日周三 下午1:10写道： > > > > > Hello Dubbo/Dubbogo Community, > > > > > > This is a call for vote to release Apache dubbo-go-pixiu version > > > v0.4.0-rc1. > > > > > > The release candidates: > > > > https://dist.apache.org/repos/dist/dev/dubbo/dubbo-go-pixiu/v0.4.0-rc1/ > > > > > > Git tag for the release: > > > https://github.com/apache/dubbo-go-pixiu/tree/v0.4.0-rc1 > > > > > > Hash for the release tag: > > > 74afc4e4c296c07082a540d43a9dfafa5867ee67 > > > > > > Release Notes: > > > https://github.com/apache/dubbo-go-pixiu/blob/develop/CHANGE.md > > > <https://github.com/apache/dubbo-go-pixiu/blob/0.4.0/CHANGE.md> > > > > > > The artifacts have been signed with Key : > > > BB21D9FEEC5A11784F4B2128950D45A68BCE0AB0, which can be > > > found in the keys file: > > > https://dist.apache.org/repos/dist/dev/dubbo/KEYS > > > > > > The vote will be open for at least 72 hours or until necessary number > of > > > votes are reached. > > > > > > > > > Please vote accordingly: > > > > > > [ ] +1 approve > > > [ ] +0 no opinion > > > [ ] -1 disapprove with the reason > > > > > > Thanks, > > > The Apache Dubbo-go Team > > > > > >
