+1 binding with some minor issues I have checked: * Hash and signature are good * Release note looks good * Source can compile * LICENSE and NOTICE are good
Some issues: - The release tag in the voting mail is unclear. I see < https://github.com/apache/dubbo-go-pixiu/releases/tag/v0.5.1-rc01> in my mail client. - The release hash (a3ed16f3a150aa44af908a4b666a388fefa52324) does not match the Git tag (v0.5.1-rc2: 0fa197579953fa5fa3039bb97b6c673599f5b800). I think we can append the correct information to this mailing list and proceed to vote. On Sun, Jul 31, 2022 at 4:09 PM stocks alex <alexsto...@apache.org> wrote: > +1 (binding) . > > I checked the following items. > > [v] Are release files in the correct location? > [v] Do LICENSE and NOTICE files exist? > [v] Is the LICENSE and NOTICE text correct? > [x] Un-included software dependencies are not mentioned in LICENSE or > NOTICE? > [x] License information is not mentioned in NOTICE? > [v] Do the contents of the release match with what's tagged in > versioncontrol? > [x] Are there any unexpected binary files in the release? > [v] Is the NOTICE year correct? > > ztelur <zte...@apache.org> 于2022年7月30日周六 21:47写道： > > > +1 (binding) . > > > > I checked the following items. > > > > [v] LICENSE and NOTICE exist and contents are good > > [v] Tag and hash can match > > [v] Signature can be found in the keys file > > [v] Release notes look fine in > > [v] Unit tests passed on my Mac > > [v] there are no any unexpected binary files in the release. > > >
