xixingya commented on code in PR #5:
URL: https://github.com/apache/dubbo-ai/pull/5#discussion_r1708986430
##########
dubbo-ai-core/src/main/java/org/apache/dubbo/ai/core/DubboAiContext.java:
##########
@@ -53,27 +53,11 @@ public class DubboAiContext {
public DubboAiContext(Class<?> aiInterfaceClass) {
this.aiInterfaceClass = aiInterfaceClass;
classAiMetadata = new ClassAiMetadata(aiInterfaceClass);
- checkOptions();
constructChatClients();
}
- /**
- * check options is same
- */
- private void checkOptions() {
- List<AiModelProviderConfig> providerConfigs =
classAiMetadata.getProviderConfigs();
- if (providerConfigs.size() == 1) {
- return;
- }
- AiModelProviderConfig pre = providerConfigs.get(0);
- for (int i = 1; i < providerConfigs.size(); i++) {
- Options preOptions = pre.getOptions();
- AiModelProviderConfig current = providerConfigs.get(i);
- Options now = current.getOptions();
- if (!preOptions.equals(now)) {
- throw new IllegalArgumentException("you config at
@DubboAiService modelConfig Options must same,please check " + pre.getName() +
" and " + current.getName());
- }
- }
+ public List<AiModelProviderConfig> getAiModelProviderConfigs() {
Review Comment:
We referred to the naming convention of spring ai, which uses "Ai" instead
of "AI" for its naming.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
