[ 
https://issues.apache.org/jira/browse/EAGLE-7?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15026742#comment-15026742
 ] 

ASF GitHub Bot commented on EAGLE-7:
------------------------------------

Github user haoch commented on a diff in the pull request:

    https://github.com/apache/incubator-eagle/pull/6#discussion_r45864902
  
    --- Diff: 
eagle-security/eagle-security-hive/src/main/java/org/apache/eagle/security/hive/jobrunning/HiveJobRunningMonitoringMain.java
 ---
    @@ -33,9 +33,9 @@
        private static final Logger LOG = 
LoggerFactory.getLogger(HiveJobRunningMonitoringMain.class);
     
        public static void main(String[] args) throws Exception{
    -        new ConfigOptionParser().load(args);
    -        System.setProperty("config.trace", "loads");
    -        Config config = ConfigFactory.load();
    +        Config config = new ConfigOptionParser().load(args);
    +        //System.setProperty("config.trace", "loads");
    --- End diff --
    
    Remove useless code


> expose storm config as individual eagle topology config
> -------------------------------------------------------
>
>                 Key: EAGLE-7
>                 URL: https://issues.apache.org/jira/browse/EAGLE-7
>             Project: Eagle
>          Issue Type: Improvement
>         Environment: production linux
>            Reporter: Edward Zhang
>            Assignee: Zhao, Qingwen
>   Original Estimate: 72h
>  Remaining Estimate: 72h
>
> Storm has many configurations which can be configured through storm.yaml, and 
> those configurations are actually can be per topology. Eagle should have a 
> capability to expose all the configurations through Eagle configuration. Some 
> examples are 
> topology.acker.executors: 2
> topology.tasks: 8     
> topology.max.spout.pending: 1000
> topology.executor.receive.buffer.size: 16384
> topology.executor.send.buffer.size: 16384
> Today we only have parallelism of bolt/spout can be configured through eagle 
> configuration.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to