[ 
https://issues.apache.org/jira/browse/EAGLE-100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15074446#comment-15074446
 ] 

ASF GitHub Bot commented on EAGLE-100:
--------------------------------------

Github user yonzhang commented on the pull request:

    https://github.com/apache/incubator-eagle/pull/46#issuecomment-167901101
  
    Comments:
    1. I want to apply the patch in my local machine. It fails, you will have 
the same issue when you apply the patch to master. You probably need collapse 
all your commits into one commits, then it will not have any conflict
    2. the script only query jmx with "qry=Hadoop:*", then we will miss other 
metric like java.lang:* etc. Can the script download everything, but use the 
configuration in eagle-collector.conf to specify which parts to preserve.
    
    I will continue to review 


> provide tools to collect hadoop jmx metrics
> -------------------------------------------
>
>                 Key: EAGLE-100
>                 URL: https://issues.apache.org/jira/browse/EAGLE-100
>             Project: Eagle
>          Issue Type: New Feature
>            Reporter: Zhao, Qingwen
>            Priority: Critical
>
> Provide scripts to collect Hadoop jmx metrics and evently sent these metrics 
> to stdout or Kafka.
> A user can easily run these scrips by crontab 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to