[
https://issues.apache.org/jira/browse/EAGLE-84?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15091519#comment-15091519
]
ASF GitHub Bot commented on EAGLE-84:
-------------------------------------
Github user anyway1021 commented on the pull request:
https://github.com/apache/incubator-eagle/pull/42#issuecomment-170446226
@haoch
The error of #51 occurs because the title of the PR is not in the expected
format, it starts with "EAGLE-114:" but not "EAGLE-114", there is an additional
":"
For sure, it's possible to support passing jira-id, do you mean in this way
we don't have to check the title, but instead form a correct title by the
script itself? I think this is a good idea, but do we need to check the
authenticity of the jira id? Please confirm.
BTW, did you mean to get author's email from the info in patch file or some
other place? Actually we can get a lot of info from a pr url, but emails may
vary in different places. E.g. my global git config takes company's account and
email as a user, but for apache projects, I have to config the local user with
github accounts, if anyone forget this, the email info in commits will be
different. So, which will be better reliable?
> Create scripts for merging PRs automatically
> --------------------------------------------
>
> Key: EAGLE-84
> URL: https://issues.apache.org/jira/browse/EAGLE-84
> Project: Eagle
> Issue Type: Task
> Reporter: Michael Wu
> Assignee: Hao Chen
> Original Estimate: 168h
> Remaining Estimate: 168h
>
> While a pull request gets passed the testing steps, and is verified as
> good-to-merge, people are willing to merge it with scripts to go through
> necessary steps automatically, and can form the message of final aggregated
> commit in a unified format. To achieve this, we are attempted to create the
> script.
> As discussed, the format of message should be like below (ignore the lines
> consisted of asterisks):
> **********************************************
> EAGLE-${ticket_number} ${ticket_title}
> ${ticket_url}
> Author: ${commiter}
> Reviewer: ${reviewer}
> Closes #${pr_number} from ${do_person}
> **********************************************
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
