[ 
https://issues.apache.org/jira/browse/EAGLE-81?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15119252#comment-15119252
 ] 

ASF GitHub Bot commented on EAGLE-81:
-------------------------------------

Github user senthilec566 commented on the pull request:

    https://github.com/apache/incubator-eagle/pull/76#issuecomment-175636078
  
    Now code is ready for Review , the only pending thing is  which API is good 
for Scanning Classes , Java SPI or Reflection ?? 
    
    Right now Notification Plugin Using Reflection tool for scanning entities.
    
    The only problem i could see in Java SPI is 
    you have to add 
    META-INF/server/<your abstract class/interface>/list of classes which 
extends/implements { i may be wrong - correct me if its wrong }.
    
    But in Reflection API :
    Reflections reflections = new Reflections("");
    Set<Class<? extends NotificationPlugin>> subTypes = 
reflections.getSubTypesOf(NotificationPlugin.class);
    



> Notification Plugin Framework
> -----------------------------
>
>                 Key: EAGLE-81
>                 URL: https://issues.apache.org/jira/browse/EAGLE-81
>             Project: Eagle
>          Issue Type: New Feature
>            Reporter: Senthilkumar
>            Assignee: Senthilkumar
>   Original Estimate: 336h
>  Remaining Estimate: 336h
>
> Today notification is only allowed for email .. We need more notification 
> methods to send alert to external system . 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to