[
https://issues.apache.org/jira/browse/EAGLE-81?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15127382#comment-15127382
]
ASF GitHub Bot commented on EAGLE-81:
-------------------------------------
Github user yonzhang commented on the pull request:
https://github.com/apache/incubator-eagle/pull/77#issuecomment-178293138
Multiple issues:
1. Config object should be injected when topology is started from driver
program. In AlertNotificationExecutor prepareConfig, we should save Config
object and use that when this bolt is running
2. In AlertDefinitionAPIEntity, we still can see "notificationType" as one
of tags (although it does not generate any real impact, we should keep it
consistent)
for " Policy evaluation and notification are possibly in different physical
machines ", I did not mean we should do sync up, but we should be aware that
listOfNotifications may be null because policy is deleted
Set<String> listOfNotifications =
policyNotificationMapping.get(entity.getTags().get(Constants.POLICY_ID));
Also, how do I verify the plugin features? Do you have unit test or sample
to trigger a notification plugin? Or I have to run an end-2-end program to
verify plugin?
> Notification Plugin Framework
> -----------------------------
>
> Key: EAGLE-81
> URL: https://issues.apache.org/jira/browse/EAGLE-81
> Project: Eagle
> Issue Type: New Feature
> Reporter: Senthilkumar
> Assignee: Senthilkumar
> Original Estimate: 336h
> Remaining Estimate: 336h
>
> Today notification is only allowed for email .. We need more notification
> methods to send alert to external system .
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
