Github user haoch commented on a diff in the pull request:
https://github.com/apache/incubator-eagle/pull/122#discussion_r55932462
--- Diff:
eagle-core/eagle-policy/eagle-policy-base/src/main/java/org/apache/eagle/policy/siddhi/SiddhiPolicyEvaluator.java
---
@@ -130,6 +133,7 @@ private SiddhiRuntime
createSiddhiRuntime(SiddhiPolicyDefinition policyDef) {
try {
executionPlanRuntime =
siddhiManager.createExecutionPlanRuntime(executionPlan);
+ executionPlanRuntime.handleExceptionWith(new
SiddhiPolicyExceptionHandler());
--- End diff --
My patch is to extend capability of customizing exception handler for
siddhi while it uses FatalExceptionHandler by default, so here we should
override our own exception handler `SiddhiPolicyExceptionHandler` and
explicitly specify by `handleExceptionWith`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
