-1 (Binding) + Signature looks good + Checksums look fine, except .sha file. + No binary files found - LICENSE and NOTICE look OK. Have some comments as put below. - Rat-check (mvn apache-rat:check) fails. Not all files have source headers. See http://www.apache.org/legal/src-headers.html. Details below. - Please make all dependencies you are pulling are Apache compatible as per http://apache.org/legal/ - Unit tests failed, details below + mvn clean package -DskipTests passed.
----- Licensing comments : -> kafka-python is under Apache License, so need not be mentioned in top level License. -> >> This product bundles AdminLTE What are these files? I dont see any files source with headers >> This product bundles "Google Fonts: Source Sans Pro" What are these files? I dont see any files source with headers Are they coming with apache headers by any chance? -> For other licenses just giving weblink from top level license is not enough. Full license need to be copied See http://www.apache.org/dev/release.html#distributing-code-under-several-licenses and the example at https://svn.apache.org/repos/asf/httpd/httpd/trunk/LICENSE ----- Missing source headers: incubator-eagle-release-0.3.0/eagle-webservice/src/main/webapp/app/partials/config/application.html incubator-eagle-release-0.3.0/eagle-webservice/src/main/webapp/app/partials/config/feature.html incubator-eagle-release-0.3.0/eagle-webservice/src/main/webapp/app/partials/config/site.html incubator-eagle-release-0.3.0/eagle-webservice/src/main/webapp/app/partials/landing.html incubator-eagle-release-0.3.0/eagle-webservice/src/main/webapp/app/public/feature/common/page/dataSrcConfig.html incubator-eagle-release-0.3.0/eagle-webservice/src/main/webapp/grunt.json incubator-eagle-release-0.3.0/eagle-webservice/src/main/webapp/META-INF/MANIFEST.MF incubator-eagle-release-0.3.0/eagle-webservice/src/main/webapp/package.json incubator-eagle-release-0.3.0/eagle-webservice/WebContent/META-INF/MANIFEST.MF incubator-eagle-release-0.3.0/eagle-security/eagle-security-hdfs-auditlog/src/main/resources/hdfsUserCommandPattern.json incubator-eagle-release-0.3.0/eagle-security/eagle-security-userprofile/detection/dev-supports/userprofile-executor-definition.json incubator-eagle-release-0.3.0/eagle-security/eagle-security-userprofile/detection/dev-supports/userprofile-policy-definition.json incubator-eagle-release-0.3.0/eagle-security/eagle-security-userprofile/detection/dev-supports/userprofile-stream-description.json incubator-eagle-release-0.3.0/eagle-security/eagle-security-userprofile/detection/dev-supports/userprofile-stream-metadata.json incubator-eagle-release-0.3.0/eagle-security/eagle-security-userprofile/detection/src/main/resources/ml-policyDef-UserProfile.txt incubator-eagle-release-0.3.0/eagle-security/eagle-security-userprofile/detection/src/main/resources/samplePolicy.json incubator-eagle-release-0.3.0/eagle-security/eagle-security-userprofile/detection/src/test/resources/ml-policyDef-UserProfile.txt incubator-eagle-release-0.3.0/eagle-security/eagle-security-userprofile/training/src/main/resources/hdfs-audit.log incubator-eagle-release-0.3.0/eagle-security/eagle-security-hbase-securitylog/src/test/resources/securityAuditLog incubator-eagle-release-0.3.0/eagle-assembly/src/main/conf/sandbox-userprofile-topology.conf ---- Failed tests: testRound2(org.apache.eagle.common.TestDateTimeUtil) ---- Thanks Amareshwari On Tue, Mar 15, 2016 at 3:28 AM, Dendukuri, Hemanth <[email protected]> wrote: > Hi all, > > > This is the incubator release of Apache Eagle, 0.3.0. > > We fixed all Major/Minor blocking > comments(License,Signature,External Jar etc..). > > Thanks to everyone who has contributed to this release. > > Here’s release notes: > https://git-wip-us.apache.org/repos/asf?p=incubator-eagle.git;a=blob_plain;f=CHANGELOG.txt;hb=refs/heads/branch-0.3.0 > > The artifacts to be voted on are located here: > https://dist.apache.org/repos/dist/dev/incubator/eagle/0.3.0-incubating/ > > The commit to be voted upon: > https://github.com/apache/incubator-eagle/commit/316fddca0ca9085af88826f6ed3c3ad0517cbff1 > > Release Tag : > https://github.com/apache/incubator-eagle/releases/tag/release-0.3.0 > > Release artifacts are signed with the following key: > https://people.apache.org/keys/committer/hdendukuri.asc > > > > > The hashes of the artifacts are as follows: > > apache-eagle-0.3.0-incubating-src.tar.gz.md5 > e9f23b133ee649f9724073d631d8f0c3 > > apache-eagle-0.3.0-incubating-src.tar.gz.sha > aca088572968a43d95acddfc638d3b7dfe120a40 > > > > The vote is open for the next 72 hours and passes if a majority of > at least three +1 PPMC votes are cast. > > [ ] +1 Release this Eagle 0.3.0 Incubator Version. > > [ ] 0 I don't feel strongly about it, but I'm okay with the > release > > [ ] -1 Do not release this package because... > > > > Thanks, > > Hemanth Dendukuri >
