Yes, I copied the file from Apache Amabari source code and modified to fix some problem, so I need to have license header in the file or in top-level LICENSE file?
- Hao On 3/17/16, 1:58 PM, "Henry Saputra" <[email protected]> wrote: >When you said "derived from Apache Amabari", did you mean you copied the >file? > >It should have Apache header too in that case. > >- Henry > >On Wed, Mar 16, 2016 at 1:14 PM, Chen, Hao <[email protected]> wrote: > >> The app.js file is derived from Apache Amabri because it’s licensed under >> Apache V2, so don’t need to declare in top-level license file. >> >> >> On 3/17/16, 1:35 AM, "Dendukuri, Hemanth" <[email protected]> wrote: >> >> >@ Hao, >> > >> >Kindly answer below questions. >> > >> >eagle-external/eagle-ambari/lib/EAGLE/package/patches/app.js comes from? >> Although it is a text file, it is 1.7M lines long so I doubt >> >that you can call it "source code". Was it generated? Was it copied from >> another project? >> > >> > >> > >> >Julian, I will execute below comments without fail. >> > >> >MD5, SHA1 and SHA512 matches. I think we should not keep other .sha file. >> > >> >Next release, I think you only need the .sha1 file; omit the .sha and >> .sha512 files. >> > >> >Also, I'm not sure if you can add and drop files from directory once the >> vote is called out. >> > >> >In future, do not alter the contents of the release candidate being >> >voted on. If there are serious issues you will need to cancel the vote >> >and make a new release candidate; if the issues are not serious you >> >should make sure to fix them in your next release. Either way, each >> >release candidate is immutable. >> > >> >In this case, the sha of the file matched the sha in the vote thread, >> >so everything is fine. >> > >> >This is the second release candidate, but the email has the same >> >subject as the first RC. Next time, I suggest that you include the RC >> >number in the email subject line and the directory name e.g. >> > >> https://dist.apache.org/repos/dist/dev/incubator/eagle/0.3.0-incubating-rc2/ >> >so that it is clear what is being voted on. >> > >> >Also, I don't think I saw a "[CANCEL] [VOTE] Release Eagle Incubating >> >Version 0.3.0" or "[RESULT] [VOTE] Release Eagle Incubating Version >> >0.3.0" message. Remember to terminate each vote thread. >> > >> > >> >Regards >> >Hemanth >>
