I saw you have implemented the suggestions from previous RCs — thank you!
Downloaded & built on JDK 1.7 Mac OS X. LICENSE, NOTICE, README files present and correct. No binaries. Ran apache-rat; there were 4 RAT failures in eagle-webservice but they were for files that did not need headers. +1 (binding) Julian > On Mar 25, 2016, at 6:07 PM, Liangfei.Su <[email protected]> wrote: > > +1, check sum verified. > mvn clean install runs ok > mvn apache-rat:check looks good > > > liasu@eagle-c3-lvs01-2-3954:~/rc3$ md5sum > apache-eagle-0.3.0-incubating-src-rc3.tar.gz > a211a151d7f66c2516c5e41da1345128 > apache-eagle-0.3.0-incubating-src-rc3.tar.gz > liasu@eagle-c3-lvs01-2-3954:~/rc3$ cat > apache-eagle-0.3.0-incubating-src-rc3.tar.gz.md5 > a211a151d7f66c2516c5e41da1345128 > liasu@eagle-c3-lvs01-2-3954:~/rc3$ sha > sha1sum sha224sum sha256sum sha384sum sha512sum > shadowconfig shasum > liasu@eagle-c3-lvs01-2-3954:~/rc3$ sha1sum > apache-eagle-0.3.0-incubating-src-rc3.tar.gz > da7b4e60228cf1421dde4342c957aff16de81cbd > apache-eagle-0.3.0-incubating-src-rc3.tar.gz > liasu@eagle-c3-lvs01-2-3954:~/rc3$ cat > apache-eagle-0.3.0-incubating-src-rc3.tar.gz.sha1 > da7b4e60228cf1421dde4342c957aff16de81cbd > > > > > > > On Thu, Mar 24, 2016 at 11:47 PM, Amareshwari Sriramdasu < > [email protected]> wrote: > >> +1 (Binding) >> >> + Verified signature >> + Verified checksum >> + Rat check (mvn apache-rat:check) is fine. Had to add the following to >> pom.xml. Would be good to have in pom itself. >> --- >> >> <excludes> >> >> <exclude>**/*.json</exclude> >> >> <exclude>**/*.patch</exclude> >> >> <exclude>**/README.md</exclude> >> >> <exclude>**/*.txt</exclude> >> >> <exclude>**/*.log</exclude> >> >> <exclude>**/kafka-python/**</exclude> >> >> <exclude>**/six/**</exclude> >> >> <exclude>**/securityAuditLog</exclude> >> >> <exclude>**/MANIFEST.MF</exclude> >> >> </excludes> >> >> ---- >> + License and NOTICE looks good. >> + DISCLAIMER exists >> + mvn clean package -DskipTests passes >> - Unit test fail for me. >> >> ---- >> >> Failed tests: >> >> testRound2(org.apache.eagle.common.TestDateTimeUtil) >> >> --- >> >> Thanks >> >> Amareshwari >> >> On Fri, Mar 25, 2016 at 11:00 AM, Hao Chen <[email protected]> wrote: >> >>> *+1 (Binding)* >>> >>> *md5, shasum, gpg, mvn clean install passed.* >>> >>> $md5 apache-eagle-0.3.0-incubating-src-rc3.tar.gz >>> MD5 (apache-eagle-0.3.0-incubating-src-rc3.tar.gz) = >>> a211a151d7f66c2516c5e41da1345128 >>> >>> $ shasum apache-eagle-0.3.0-incubating-src-rc3.tar.gz >>> da7b4e60228cf1421dde4342c957aff16de81cbd >>> apache-eagle-0.3.0-incubating-src-rc3.tar.gz >>> >>> $ gpg --verify apache-eagle-0.3.0-incubating-src-rc3.tar.gz.asc.txt >>> apache-eagle-0.3.0-incubating-src-rc3.tar.gz >>> gpg: Signature made Tue Mar 22 07:33:30 2016 CST using RSA key ID >> BB7D5724 >>> gpg: Good signature from "Hemanth Dendukuri (CODE SIGNING KEY) < >>> [email protected]>" >>> >>> $ mvn clean install >>> ... >>> [INFO] >>> ------------------------------------------------------------------------ >>> [INFO] BUILD SUCCESS >>> [INFO] >>> ------------------------------------------------------------------------ >>> [INFO] Total time: 6:57.329s >>> [INFO] Finished at: Fri Mar 25 13:28:59 CST 2016 >>> [INFO] Final Memory: 376M/1948M >>> [INFO] >>> ------------------------------------------------------------------------ >>> >>> - Hao >>> >>> On Fri, Mar 25, 2016 at 1:29 AM, Dendukuri, Hemanth <[email protected] >>> >>> wrote: >>> >>>> Hi all, >>>> >>>> >>>> This is the incubator release of Apache Eagle, 0.3.0 Release >>>> Candidate 3. >>>> >>>> We fixed all comments. >>>> >>>> Thanks to everyone who has contributed to this release. >>>> >>>> Here’s release notes: >>>> >>> >> https://git-wip-us.apache.org/repos/asf?p=incubator-eagle.git;a=blob_plain;f=CHANGELOG.txt;hb=refs/heads/branch-0.3.0 >>>> >>>> The artifacts to be voted on are located here: >>>> >>> >> https://dist.apache.org/repos/dist/dev/incubator/eagle/0.3.0-incubating-rc3/ >>>> >>>> The commit to be voted upon: >>>> >>> >> https://github.com/apache/incubator-eagle/commit/b1d0a87ac0df1cc881427faafc637c152c180872 >>>> >>>> Release Tag : >>>> >> https://github.com/apache/incubator-eagle/releases/tag/release-0.3.0-rc3 >>>> >>>> Release artifacts are signed with the following key: >>>> https://people.apache.org/keys/committer/hdendukuri.asc >>>> >>>> >>>> >>>> >>>> The hashes of the artifacts are as follows: >>>> >>>> apache-eagle-0.3.0-incubating-src-rc3.tar.gz.md5 >>>> a211a151d7f66c2516c5e41da1345128 >>>> >>>> apache-eagle-0.3.0-incubating-src-rc3.tar.gz.sha1 >>>> da7b4e60228cf1421dde4342c957aff16de81cbd >>>> >>>> >>>> >>>> The vote is open for the next 72 hours and passes if a majority >> of >>>> at least three +1 PPMC votes are cast. >>>> >>>> [ ] +1 Release this Eagle 0.3.0 Incubator Release Candidate 3. >>>> >>>> [ ] 0 I don't feel strongly about it, but I'm okay with the >>>> release >>>> >>>> [ ] -1 Do not release this package because... >>>> >>>> >>>> >>>> Thanks, >>>> >>>> Hemanth Dendukuri >>>> >>> >>
