Hi all, Voting for the release of Apache Eagle 0.4.0-incubating (Release Candidate 1) has been cancelled because of having the following issues: 1. The extracted directory name is inappropriate, with "rc" inside. 2. CHANGELOG first line doesn't meet branding guidelines, and it doesn't retain changelogs of previous releases. 3. version mentioned in the release goes against X.Y.Z-incubating 4. README.md doesn't highlight the software prerequisites. 5. license check doesn't pass.
Sorry for the inappropriate RC1, thank you to everyone who voted. I'll fix the findings and create RC3 for voting in dev mail list shortly (RC2 has been rejected before I sent this RC1 cancelling which comes a bit late). Thanks. Michael On Mon, Jul 4, 2016 at 11:36 PM, Michael Wu <[email protected]> wrote: > @ Hao, thanks for your advises, here are the reasons: > > 1. I thought the voting subject was something like a summarizing title, > and considering the "incubator" inside the project name, I didn't make it > with the format of "Apache Eagle x.y.z-incubating". I can change the vote > subject in the next loop if you feel it makes more sense. > 2. I didn't erase the content of previous releases from CHANGELOG.txt, > what I did was just creating it with JIRA tool against 0.4.0 and extracting > the highlights. I didn't think of adding the previous changelogs records to > it, I'll merge the ones in the next vote loop. BTW, I ever asked for advise > before I put the generated CHANGELOG.txt inside the project, but with no > response, I'd afraid if we could find missing part earlier, this shouldn't > be an issue. > > Also to @Julian: thanks to all your suggestions, so that we can improve in > the next one. > > Michael > > On Sat, Jul 2, 2016 at 2:56 AM, Hao Chen <[email protected]> wrote: > >> The source code was built successfully with JDK 1.7 under Mac OSX, md5 & >> sha check passed. >> >> I would [+1] once these issues was resolved :-) >> >> - Hao >> >> On Fri, Jul 1, 2016 at 9:57 AM, Hao Chen <[email protected]> wrote: >> >> > Michael, >> > >> > As we already agreed referring to previous releasing, please use "Apache >> > Eagle x.y.z-incubating" where "Apache Eagle" is *product name* and >> > "x.y.z-incubating" is the actual *version*, and why is there >> "incubator" in >> > the name? >> > >> > BTW: why do you erase content of previous release versions in >> > CHANGELOG.txt but just keep v0.4.0's ? I think the CHANGELOG.txt should >> > track all historical changes instead of certain version. >> > >> > - Hao >> > >> > On Fri, Jul 1, 2016 at 9:31 AM, Julian Hyde <[email protected]> wrote: >> > >> >> “Apache" has to be present, and so does “incubating”, and your version >> >> number should not start with “v". As for the order of words, I did a >> >> search[1] for recent releases and there’s no clear standard: >> >> >> >> * Apache Taverna Command-line 3.1.0-incubating >> >> * Apache Trafodion (incubating) release 2.0.1-incubating >> >> * Apache Slider 0.91.0-incubating >> >> * Apache Atlas version 0.7-incubating >> >> >> >> I think I’d go with “Apache Eagle x.y.z-incubating” as the release >> name. >> >> I’d refer to the project as “Apache Eagle (incubating)” on first >> mention >> >> and “Eagle” thereafter. >> >> >> >> Julian >> >> >> >> [1] >> >> >> https://lists.apache.org/[email protected]:lte=1M:release >> >> >> >> > On Jun 30, 2016, at 7:20 PM, Michael Wu <[email protected]> wrote: >> >> > >> >> > @Julian, >> >> > >> >> > Thanks for your valuable instructions. I have a chronic uncertainty >> on >> >> > which text we should use: "Apache Incubator Eagle vX.Y.Z" or "Apache >> >> Eagle >> >> > vX.Y.Z (incubator)", now looking at your suggestions, it seems we can >> >> use >> >> > the latter (with "incubator" enclosed by brackets), am I correct? >> >> > >> >> > Next, I'll change the dir name inside the tar, modify release note >> >> > head-line, highlight the building requirement of npm in README.md, >> add >> >> > LICENSE to asf_logo.svg, they could be done shortly. As to branding >> >> issues, >> >> > it may take some time to detect and change all the clauses. I'll >> raise >> >> > another VOTE for rc2 when they are all done. >> >> > >> >> > Thank you. >> >> > Michael >> >> > >> >> > On Fri, Jul 1, 2016 at 6:21 AM, Julian Hyde <[email protected]> >> wrote: >> >> > >> >> >> Downloaded, built successfully using JDK 1.7 on OS X. Checked >> >> signatures, >> >> >> license, notice. >> >> >> >> >> >> The directory inside the tar file is called >> >> >> apache-eagle-0.4.0-incubating-src-rc1. I would name it >> >> >> apache-eagle-0.4.0-incubating-src, because when it is released it >> will >> >> be a >> >> >> release, not a release candidate. >> >> >> >> >> >> The first line of the release notes doesn’t meet branding >> guidelines: >> >> >> "Release Notes - Eagle - Version v0.4.0” should be "Release Notes - >> >> Apache >> >> >> Eagle 0.4.0 (integrating)” >> >> >> >> >> >> The first build failed because npm was not installed. You should >> >> probably >> >> >> mention that in README.md. >> >> >> >> >> >> I ran apache-rat and got one failure: >> eagle-docs/images/asf_logo.svg. >> >> >> >> >> >> -1 because of the branding issues. It would be nice if you fixed the >> >> other >> >> >> issues this release, but it would be OK if you fixed them in the >> >> previous >> >> >> release. >> >> >> >> >> >> Julian >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> >>> On Jun 30, 2016, at 7:55 AM, Michael Wu <[email protected]> >> wrote: >> >> >>> >> >> >>> Hi all, >> >> >>> >> >> >>> This is a release vote for Apache Incubator Eagle, version 0.4.0, >> >> release >> >> >>> candidate 1. >> >> >>> >> >> >>> Highlighted changes in this release are as the following: >> >> >>> * JBDC Metadata Storage Extension >> >> >>> * Topology management in remote mode including start/stop/status >> >> >>> operations >> >> >>> * Auditlogparser for MapR's audit log >> >> >>> * Oozie auditlog integration for Oozie security monitoring >> >> >>> * Add applicaiton "maprFSAuditLog" >> >> >>> * Refactor bin/eagle-sandbox-starter.sh to make it easier to use >> >> >>> >> >> >>> Thanks to everyone who has contributed to this release. >> >> >>> >> >> >>> Here's the release note: >> >> >>> >> >> >> >> >> >> https://git-wip-us.apache.org/repos/asf?p=incubator-eagle.git;a=blob_plain;f=CHANGELOG.txt;hb=refs/heads/branch-0.4 >> >> >>> >> >> >>> The artifacts to be voted on are located at: >> >> >>> >> >> >> >> >> >> https://dist.apache.org/repos/dist/dev/incubator/eagle/v0.4.0-incubating-rc1/ >> >> >>> >> >> >>> The commit to be voted upon: >> >> >>> >> >> >> >> >> >> https://github.com/apache/incubator-eagle/commit/73c8e023bd2c9d620c4938773fa147756f48ce0a >> >> >>> >> >> >>> Release tag is: >> >> >>> >> >> >> >> >> >> https://github.com/apache/incubator-eagle/releases/tag/v0.4.0-incubating-rc1 >> >> >>> >> >> >>> Release artifacts are signed with the following key: >> >> >>> http://people.apache.org/keys/committer/mw.asc >> >> >>> >> >> >>> The hashes of the artifacts are as follows: >> >> >>> apache-eagle-0.4.0-incubating-src-rc1.tar.gz.md5: >> >> >>> d22c91d7eb6a0c5a9067b2ae69f98bfe >> >> >>> apache-eagle-0.4.0-incubating-src-rc1.tar.gz.sha1: >> >> >>> 6c337c0d6239f40879eba2a4c535d2b737b44fea >> >> >>> >> >> >>> Please vote on releasing this package as: Apache Incubator Eagle >> >> v0.4.0. >> >> >>> >> >> >>> The vote is open for the next 72 hours and passes if a majority of >> at >> >> >> least >> >> >>> three +1 PPMC votes are cast. >> >> >>> >> >> >>> [ ] +1 Release this Apache Eagle 0.4.0-incubating Release >> Candidate 1. >> >> >>> >> >> >>> [ ] 0 I don't feel strongly about it, but I'm okay with the >> release >> >> >>> >> >> >>> [ ] -1 Do not release this package because... >> >> >>> >> >> >>> >> >> >>> Thanks. >> >> >>> Michael Wu >> >> >> >> >> >> >> >> >> >> >> > >> > >
