Github user haoch commented on the issue:
https://github.com/apache/incubator-eagle/pull/312
LGTM, except:
1. MetadataDaoFactory, but we could refactor this later
2. Prefer to rename configuration key "connection" as "metadata.connection"
If we want to use json-style configuration, we should well org
configuration by `{}` object group.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
