[
https://issues.apache.org/jira/browse/EAGLE-455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15418246#comment-15418246
]
ASF GitHub Bot commented on EAGLE-455:
--------------------------------------
Github user haoch commented on the issue:
https://github.com/apache/incubator-eagle/pull/331
I think the implementation is to provide the foundation for make sure the
code modules extensible, as how much code developer should write it's to
continue simplifying the interface or DSL. I was told to think interface
earlier than implementation.
> - Further, what if the application needs know configuration for eagle
server
We should follow the defined interface of Application. For Application
standalone mode, the configuration should be passed through configuration file,
for Application managed by server, the configuration should be passed through:
https://github.com/apache/incubator-eagle/blob/develop/eagle-core/eagle-app/eagle-app-base/src/main/java/org/apache/eagle/app/service/ApplicationContext.java#L70
this.config =
ConfigFactory.parseMap(executionConfig).withFallback(envConfig);
For managed classes, it could easily get server config by `@Inject Config
config;`
> Provide shared JDBCQueryService for JDBCMetadataStore
> -----------------------------------------------------
>
> Key: EAGLE-455
> URL: https://issues.apache.org/jira/browse/EAGLE-455
> Project: Eagle
> Issue Type: New Feature
> Reporter: Hao Chen
> Assignee: Hao Chen
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
