[ 
https://issues.apache.org/jira/browse/EAGLE-474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15427106#comment-15427106
 ] 

ASF GitHub Bot commented on EAGLE-474:
--------------------------------------

GitHub user yonzhang opened a pull request:

    https://github.com/apache/incubator-eagle/pull/362

    app framework improvement of appId, jarPath

    https://issues.apache.org/jira/browse/EAGLE-474

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/yonzhang/incubator-eagle develop

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-eagle/pull/362.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #362
    
----
commit b5600c66aead1d4977c29fe0b132a55807fd1663
Author: yonzhang <yonzhang2...@gmail.com>
Date:   2016-08-18T20:43:50Z

    app framework improvement of appId, jarPath

----


> some improvements of app framework: appId naming, jarFile field, 
> InstallOperation etc.
> --------------------------------------------------------------------------------------
>
>                 Key: EAGLE-474
>                 URL: https://issues.apache.org/jira/browse/EAGLE-474
>             Project: Eagle
>          Issue Type: Improvement
>    Affects Versions: v0.5.0
>            Reporter: Edward Zhang
>            Assignee: Edward Zhang
>            Priority: Minor
>             Fix For: v0.5.0
>
>
> App framework has some bugs and also needs some improvement
> 1. appId in ApplicationEntity should not contain "[,]" chars, which will make 
> storm UI not show the topology details
> 2. jarPath is not necessary to be part of ApplicationDesc or metadata xml file
> 3. InstallOperation should contain jarPath which should be in the same level 
> of appType etc.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to