[
https://issues.apache.org/jira/browse/EAGLE-458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15427572#comment-15427572
]
ASF GitHub Bot commented on EAGLE-458:
--------------------------------------
Github user haoch commented on the issue:
https://github.com/apache/incubator-eagle/pull/335
`metadata.xml` is part of code, `application.conf` should just for
standalone running mode. We should never mix them, the `value` in
`metadata.xml` just stands for `defaultValue` and should be treated as
configuration file. Currently we still have to manually do it. And for some
application, i may have tens of configuration items like this app.
Better solution is make the `configuration` in `metadata.xml` be part of
code as designed before like:
~~~
AppConfiguration{
@Property(name="eagle.app.configName",displayName="ConfigName",
defaultValue="defaultValue")
public String configName;
}
~~~
It should be good for:
1. Provide metadata inline in typesafe way and avoid ugly get configuration
by Config.getXXX method hidden in logic code.
2. Automatically map configuration instance from typesafe Config through
annotation.
> Convert spark running app using new app framework
> -------------------------------------------------
>
> Key: EAGLE-458
> URL: https://issues.apache.org/jira/browse/EAGLE-458
> Project: Eagle
> Issue Type: Sub-task
> Reporter: Hao Chen
> Assignee: Hao Chen
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
